Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm32 to the list of target architectures of the simd feature #316

Closed
roee88 opened this issue May 18, 2021 · 0 comments · Fixed by #324
Closed

Add wasm32 to the list of target architectures of the simd feature #316

roee88 opened this issue May 18, 2021 · 0 comments · Fixed by #324
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@roee88
Copy link
Contributor

roee88 commented May 18, 2021

packed_simd compiles to wasm32-wasi and wasm32-unknown-unknown targets (and includes CI against it). It will only work on WASM runtimes that support the WASM SIMD proposal but that's no reason to block it from arrow-rs side.

Describe the solution you'd like

Add wasm32 to

simd: { all(any(target_arch = "x86", target_arch = "x86_64", target_arch = "aarch64"), feature = "simd") },

Describe alternatives you've considered

Optional features should not be limited to specific architectures in arrow-rs itself. The arrow-rs CI shouldn't run tests with combinations that are not known to work, but as a user I would expect that if I enable a feature then it's enabled (and might create a failure on its own if it doesn't work yet). It took me a while to understand why I get the error described in #232 when targeting wasm32. This would probably require changes to the CI workflows though.

@roee88 roee88 added the enhancement Any new improvement worthy of a entry in the changelog label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant