Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FlightSQL] Add Builder for configuring options on flight sql client #3308

Open
Tracked by #3301
alamb opened this issue Dec 9, 2022 · 0 comments
Open
Tracked by #3301

[FlightSQL] Add Builder for configuring options on flight sql client #3308

alamb opened this issue Dec 9, 2022 · 0 comments
Labels
arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Dec 9, 2022 •
edited
Loading

As suggested by @viirya in #3207 (comment)

I think we may come with a option struct and have these as default values. And users can specify them if needed.

The basic idea would be that the FlightSqlServiceClient would take a options struct. Now they are hard coded

let options = FlightSqlOptions::new();
let client = FlightSqlServiceClient::try_new(options).await?
This was referenced Dec 9, 2022
Closed
Merged
@alamb alamb added arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog labels Dec 9, 2022
@alamb alamb mentioned this issue Dec 27, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite FlightSQL client in terms of the mid level client (WIP) alamb/arrow-rs
1 participant
@alamb