object-store: aws_profile fails to load static credentials

[helmus]

Describe the bug

Loading credentials trough an aws_profile is currently not working because the expiration value of the credential is evaluated incorrectly.

The following call to c.expiry() will always return None, resulting in an Invalid expiry error.

arrow-rs/object_store/src/aws/credential.rs

Lines 558 to 566 in 96791ea

	let expiry = match c.expiry().and_then(|e| e.duration_since(t_now).ok()) {
	Some(ttl) => Instant::now() + ttl,
	None => {
	return Err(crate::Error::Generic {
	store: "S3",
	source: "Invalid expiry".into(),
	})
	}
	};

The expiry() method returns the expires_after field, which is not loaded from the aws_profile, but instead is made optionally available to the caller as a caching ttl field. ( reference for that here , there is an expiry_mut() method as well, allowing the caller to modify the expiration. ).

As such this value will always be None. A value of None means the credential does not expire at all.
Currently the referenced code evaluates an expiry of None as an invalid expiry.

To Reproduce
attempt to load a file from s3 trough an aws_profile, Invalid expiry will be shown.

Expected behavior

The query should execute correctly.

Additional context

[tustvold]

Does your profile contain static credentials? I'm wondering if the issue here is that the aws-profile logic is not currently handling this, which we should fix, but interpreting the expiry is still correct for ephemeral credentials such as those obtained from sso?