New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window::shift shall properly handle boundary cases #387

Closed

jimexist opened this issue May 31, 2021 · 0 comments · Fixed by #386

Labels

bug

Member

jimexist commented May 31, 2021 •

edited

Loading

Describe the bug
A clear and concise description of what the bug is.

arrow/src/compute/kernels/window.rs shall handle special cases of shifts:

0
large off size offsets
i64::MIN

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

for 0 it shall return unshifted array
for large offsets it shall return all null array

Additional context
Add any other context about the problem here.

The text was updated successfully, but these errors were encountered:

jimexist added the bug label

jimexist mentioned this issue

add more tests for window::shift and handle boundary cases #386

Merged

alamb closed this as completed in #386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment