Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my contribution not marged in 4.2 release #394

Closed
kazuk opened this issue Jun 3, 2021 · 7 comments
Closed

my contribution not marged in 4.2 release #394

kazuk opened this issue Jun 3, 2021 · 7 comments
Labels

Comments

@kazuk
Copy link
Contributor

kazuk commented Jun 3, 2021

Describe the bug

I add a with_escape and some function into arrow::csv::reader::ReaderBuilder.

PR: #326

but docs.rs document for 4.2.0 not contains this.
https://docs.rs/arrow/4.2.0/arrow/csv/reader/struct.ReaderBuilder.html

and my own code for 4.2.0, build failed with this error.

error[E0599]: no function or associated item named `with_escape` found for struct `arrow::csv::ReaderBuilder` in the current scope

To Reproduce
Steps to reproduce the behavior: write code using ReaderBuilder::with_escape .

Expected behavior
compilation success

Additional context

tag 4.2.0 seems contains my commits.
4.2.0...master

seems something error in release process around cargo publish

@kazuk kazuk added the bug label Jun 3, 2021
@alamb
Copy link
Contributor

alamb commented Jun 4, 2021

Sorry @kazuk -- I a still working out the backport procedure. I have created a PR here #407 (which if merged will become part of arrow-rs 4.3).

@alamb
Copy link
Contributor

alamb commented Jun 4, 2021

(eta of 4.3 is in ~ 1 week -- I hope to make the RC June 11)

@kazuk
Copy link
Contributor Author

kazuk commented Jun 4, 2021

thanks @alamb
I keep wait 4.3 release.

Can you change release tag page?

https://github.com/apache/arrow-rs/releases/tag/4.2.0

this shows 33 commits to master since this tag.
that's references branch master, released binary branch active_release.

@alamb
Copy link
Contributor

alamb commented Jun 5, 2021

I keep wait 4.3 release.

Thank you

Can you change release tag page?
https://github.com/apache/arrow-rs/releases/tag/4.2.0
this shows 33 commits to master since this tag.
that's references branch master, released binary branch active_release.

I am not sure how to change how github reports commits since a branch on the tags page. Can you explain more of what you would like me to do?

However, I have gone and made a 4.0.0 tag in the arrow-rs repo, so now you can see what was included in 4.2.0 compared to 4.0.0 by comparing those tags: 4.0.0...4.2.0

@kazuk
Copy link
Contributor Author

kazuk commented Jun 7, 2021

I check repository setting page on github.

that link depends default base branch setting. and not fits this repo.

I close this issue . Thank you.

@kazuk kazuk closed this as completed Jun 7, 2021
@alamb
Copy link
Contributor

alamb commented Jun 14, 2021

@kazuk 4.3.0 has been released

https://crates.io/crates/arrow/4.3.0

@kazuk
Copy link
Contributor Author

kazuk commented Jun 16, 2021

I test arrow-rs and parquet-rs 4.3.0 with my code.

that works fine!

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants