Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrimitiveDictionaryBuilder.finish should use actual value type #3971

Closed
viirya opened this issue Mar 28, 2023 · 0 comments · Fixed by #3972
Closed

PrimitiveDictionaryBuilder.finish should use actual value type #3971

viirya opened this issue Mar 28, 2023 · 0 comments · Fixed by #3972
Labels
arrow Changes to the arrow crate bug

Comments

@viirya
Copy link
Member

viirya commented Mar 28, 2023

Describe the bug

This is a follow up of #3776. When doing finish on PrimitiveDictionaryBuilder, we didn't use actual value type.

To Reproduce

Expected behavior

Additional context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PrimitiveDictionaryBuilder.finish should use actual value type viirya/arrow-rs
2 participants
@viirya @tustvold