Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Type Declarations for All Primitive Tensors and Buffer Builders #4112

Closed
izveigor opened this issue Apr 22, 2023 · 1 comment · Fixed by #4113
Closed

Add Type Declarations for All Primitive Tensors and Buffer Builders #4112

izveigor opened this issue Apr 22, 2023 · 1 comment · Fixed by #4113
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@izveigor
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I suggest add missing data types for tensors and buffer builders.
After these changes tensors and buffer builders will support all primitive data types.

Describe the solution you'd like
The following tensors and buffer builders will be added:
Tensors:

  • Date32Tensor
  • Date64Tensor
  • Decimal128Tensor
  • Decimal256Tensor
  • DurationMicrosecondTensor
  • DurationMillisecondTensor
  • DurationNanosecondTensor
  • DurationSecondTensor
  • IntervalDayTimeTensor
  • IntervalMonthDayNanoTensor
  • IntervalYearMonthTensor
  • Time32MillisecondTensor
  • Time32SecondTensor
  • Time64MicrosecondTensor
  • Time64NanosecondTensor
  • TimestampMicrosecondTensor
  • TimestampMillisecondTensor
  • TimestampNanosecondTensor
  • TimestampSecondTensor

Buffer builders:

  • Float16BufferBuilder
  • Decimal128BufferBuilder
  • Decimal256BufferBuilder

Describe alternatives you've considered

Additional context
@izveigor izveigor added the enhancement Any new improvement worthy of a entry in the changelog label Apr 22, 2023
@izveigor izveigor mentioned this issue Apr 22, 2023
Merged
@tustvold tustvold changed the title Support all primitive tensors and buffer builders Add Type Declarations for All Primitive Tensors and Buffer Builders Apr 25, 2023
@tustvold tustvold added the arrow Changes to the arrow crate label May 5, 2023
@tustvold
Copy link
Contributor

tustvold commented May 5, 2023

label_issue.py automatically added labels {'arrow'} from #4113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Type Declarations for All Primitive Tensors and Buffer Builders
2 participants
@tustvold @izveigor