Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[object_store] Retry requests on connection error #4119

Closed
kindly opened this issue Apr 24, 2023 · 1 comment · Fixed by #4120
Closed

[object_store] Retry requests on connection error #4119

kindly opened this issue Apr 24, 2023 · 1 comment · Fixed by #4120
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface

Comments

@kindly
Copy link
Contributor

kindly commented Apr 24, 2023

Describe the bug

When doing mulitipart uploads to s3, for larger files, I was getting lots of reqwest/hyper errors, e.g broken pipe, tls handshake errors and channel closed, meaning some large files become almost impossible to upload. This could be due to flaky internet or slow processing of data being uploaded.

To Reproduce

Hard to reproduce as they were intermittent failures and required large files or delays between requests.

Expected behaviour

Ability for the put requests/multiplart uploads to be retried for more failure cases.

Additional context

Pull request #4120 does retries for more cases, which fixes these issues for me.

@kindly kindly added the bug label Apr 24, 2023
@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog and removed bug labels Apr 25, 2023
@tustvold tustvold changed the title [object_store] Intermittent failure to put data, especially in multipart uploads. [object_store] Retry requests on connection error Apr 25, 2023
@tustvold tustvold added the object-store Object Store Interface label May 5, 2023
@tustvold
Copy link
Contributor

tustvold commented May 5, 2023

label_issue.py automatically added labels {'object-store'} from #4120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants