Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object_store: different behavior from aws cli for default profile #4137

Closed
Renkai opened this issue Apr 26, 2023 · 4 comments · Fixed by #4238
Closed

object_store: different behavior from aws cli for default profile #4137

Renkai opened this issue Apr 26, 2023 · 4 comments · Fixed by #4238
Labels
bug object-store Object Store Interface

Comments

@Renkai
Copy link

Renkai commented Apr 26, 2023

Describe the bug
Object store doesn't use the default profile in ~/.aws/config

To Reproduce

  • compile with flag aws_profile
  • Have [default] section in ~/.aws/config
  • No AWS_PROFILE value
  • object store ignored the content in [default]

Expected behavior
object store uses the [default] section for s3 even if there is no AWS_PROFILE in the environment variables

Additional context
Maybe related code position:
https://github.com/apache/arrow-rs/blob/master/object_store/src/aws/mod.rs#L1040

@Renkai Renkai added the bug label Apr 26, 2023
@tustvold
Copy link
Contributor

What happens if you set AWS_PROFILE=default, is this an acceptable workaround?

I'm struggling to devise a way to achieve this without potentially breaking downstreams in unpredictable ways, we only want to use the aws-config credentials (used to provide AWS_PROFILE) if explicitly opted into by the user. As feature flags should be strictly additive, they are insufficient to gate this functionality.

@Renkai
Copy link
Author

Renkai commented Apr 27, 2023

It's acceptable workaround, but I also hope there is a warn message when I expect the default profile without the environment variable set but object_store decide not.

@tustvold
Copy link
Contributor

tustvold commented May 2, 2023

FYI #4163 might provide a mechanism for users to opt-in to AWS CLI compatibility, by using the CLI to generate the credentials

@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'object-store'} from #4238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug object-store Object Store Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants