Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have array_to_json_array support FixedSizeList #4248

Closed
dadepo opened this issue May 20, 2023 · 2 comments · Fixed by #4361
Closed

Have array_to_json_array support FixedSizeList #4248

dadepo opened this issue May 20, 2023 · 2 comments · Fixed by #4361
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@dadepo
Copy link
Contributor

dadepo commented May 20, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Using array_to_json_array to convert an arrow ArrayRef into a Vec of Serde JSON fails if the ArrayRef is FixedSizeList

Looking at the source here it looks like it is indeed missing handling of FixedSizeList

Describe the solution you'd like
It should be possible to use array_to_json_array to convert ArrayRef into a Vec of Serde JSON

Version: arrow-json = "39.0.0"
@dadepo dadepo added the enhancement Any new improvement worthy of a entry in the changelog label May 20, 2023
@alamb
Copy link
Contributor

alamb commented May 25, 2023

Related discussion: apache/datafusion#6446

@dadepo dadepo mentioned this issue Jun 4, 2023
Merged
@alamb
Copy link
Contributor

alamb commented Jun 16, 2023

label_issue.py automatically added labels {'arrow'} from #4361

@alamb alamb added the arrow Changes to the arrow crate label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for FixedSizeList in array_to_json_array dadepo/arrow-rs
2 participants
@dadepo @alamb