Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support casting temporal types to dictionary #4390

Open
wjones127 opened this issue Jun 9, 2023 · 0 comments
Open

Support casting temporal types to dictionary #4390

wjones127 opened this issue Jun 9, 2023 · 0 comments
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@wjones127
Copy link
Member

wjones127 commented Jun 9, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Hit this line when trying to cast date32 to dictionary(_, date32):

"Unsupported output type for dictionary packing: {dict_value_type:?}"

Describe the solution you'd like

Update can_cast_types to return false for types cast_to_dictionary doesn't support, like temporal types, floats, and bools.

pub fn can_cast_types(from_type: &DataType, to_type: &DataType) -> bool {

Describe alternatives you've considered

Fill in at least temporal types, floats and bools in the cast_to_dictionary method. But it sounds like we don't intend to support dictionary encoding for these types.

Additional context

@wjones127 wjones127 added arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog labels Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

1 participant