[objectstore] Problem with special characters in file path

[timvw]

Describe the bug
Files with special characters (@, %) are not supported by ObjectStore.

They are happily accepted on local filesystem and/or S3 though..

To Reproduce
touch "test@dir%2523with_special%2520characters.parquet"

eg: Error: ObjectStore(NotFound { path: "/Users/tim/src/github/qv/test@dir%2523with_special%2520characters.parquet", source: Os { code: 2, kind: NotFound, message: "No such file or directory" } })

Expected behavior
Would like these paths also to be supported

Additional context
Would solve timvw/qv#70

[tustvold]

This is by design see https://docs.rs/object_store/latest/object_store/path/struct.Path.html#path-safety. You need to use Path::parse if you are providing an already escaped path.

For example the following works

#[tokio::test]
async fn test_escaped() {
    let root = TempDir::new().unwrap();
    let integration = LocalFileSystem::new_with_prefix(root.path()).unwrap();
    let path =
        Path::parse("test@dir%2523with_special%2520characters.parquet").unwrap();
    integration.put(&path, "foo".into()).await.unwrap();

    integration.head(&path).await.unwrap();
}