Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exports are not sufficient for configuring some object stores, for example minio running locally #4530

Closed
winding-lines opened this issue Jul 16, 2023 · 2 comments
Labels
bug object-store Object Store Interface

Comments

@winding-lines
Copy link
Contributor

winding-lines commented Jul 16, 2023

Describe the bug
When running minio locally for testing the default setup is to use http. The object_store crate supports this setup, however one of the required symbols is not exported.

To Reproduce

In order to connect with minio over http you'd use code similar to the following

use object_store::AmazonS3ConfigKey as Key;
use object_store::ClientConfigKey; // <- export missing
use object_store::aws::AmazonS3Builder;

def foo() {
        
  let out builder = AmazonS3Builder().new();
  builder = builder.with_config(Key::AccessKeyId, &cred.access_key.unwrap());
  builder = builder.with_config(Key::SecretAccessKey, &cred.secret_key.unwrap());
  builder = builder.with_config(Key::Client(ClientConfigKey::AllowHttp), &"true".into());
  builder = builder.with_config(Key::Endpoint, &"http://localhost:9000".into()));
}

Expected behavior
The code should compile, but it does not because of the private ClientConfigKey.

Additional context

@winding-lines
Copy link
Contributor Author

Looks like this was already fixed as part of #4515

@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'object-store'} from #4531

@tustvold tustvold added the object-store Object Store Interface label Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug object-store Object Store Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants