Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request Labeler is not working #462

Closed
alamb opened this issue Jun 16, 2021 · 1 comment · Fixed by #468
Closed

Pull Request Labeler is not working #462

alamb opened this issue Jun 16, 2021 · 1 comment · Fixed by #468
Labels

Comments

@alamb
Copy link
Contributor

alamb commented Jun 16, 2021

Describe the bug
The automatic labeler job (in Dev PR / "Process") https://github.com/apache/arrow-rs/blob/master/.github/workflows/dev_pr.yml#L23-L39 is supposed to label Pull Requests based on what files they change, but it does not appear to be working

To Reproduce
Make a PR

Expected behavior
PRs should automatically be labeled with arrow, parquet, etc labels depending on what files are changed;

Additional context
The labeler came from the original in arrow: https://github.com/apache/arrow/blob/master/.github/workflows/dev_pr.yml#L65-L74

Which seems to be working

@alamb alamb added the bug label Jun 16, 2021
@Dandandan
Copy link
Contributor

Checking the difference yields:

on:
  # TODO: Enable this when eps1lon/actions-label-merge-conflict is available.
  # push:
  #   branches:
  #     - master
  pull_request_target:
    types:
      - opened
      - edited
      - synchronize

This version:

on:
  pull_request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants