-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support equality of StructArray #5199
Labels
enhancement
Any new improvement worthy of a entry in the changelog
Comments
my-vegetable-has-exploded
added
the
enhancement
Any new improvement worthy of a entry in the changelog
label
Dec 11, 2023
@tustvold do you know if there any fundamental reason we can't compare struct arrays for equality (by recursively checking each field)? |
Not that I am aware of, should be fairly straightfoward |
Thanks for the reply. If this enhancement is not so urgent, I am willing to submit a pr later. |
I don't believe there is any particular urgency on this one, thank you |
Dandandan
changed the title
Support equality of StrutArray
Support equality of StructArray
Dec 12, 2023
I agree there is no urgency from my perspective |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
In datafusion #6635, we think convert tuple to struct will be helpful to implement multi column In list.
But StructAray is not comparable in arrow-rs since it is nested.
arrow-rs/arrow-ord/src/cmp.rs
Lines 201 to 205 in 7e28913
Describe the solution you'd like
I don't know if this feature is already implemented in arrow.
In my view, compare PrimitiveArray may be rather different from NestedArray. Take equality of StrutArray as an example, I think it may need those steps:
The process slightly differs from the
apply_op
process.arrow-rs/arrow-ord/src/cmp.rs
Lines 361 to 364 in 7e28913
Describe alternatives you've considered
Additional context
The equality of other array type may need more further consideration. Like equality for ListArray, shall we considerate out of order between list(which means that whether [[1,2]] and [[2,1]] are equal or not)?
The text was updated successfully, but these errors were encountered: