Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primitive sorting can be improved and more consistent with and without limit if sorted unstably #553

Closed
jimexist opened this issue Jul 14, 2021 · 0 comments · Fixed by #552
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@jimexist
Copy link
Member

jimexist commented Jul 14, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)

use sort_unstable_by in primitive sorting so that we can have:

  1. better memory footprint
  2. faster sort
  3. consistent stableness behavior with and without limit

Describe the solution you'd like
A clear and concise description of what you want to happen.

use sort_unstable_by in primitive sorting

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@jimexist jimexist added the enhancement Any new improvement worthy of a entry in the changelog label Jul 14, 2021
@jimexist jimexist changed the title use sort_unstable_by in primitive sorting primitive sorting can be improved and more consistent with and without limit if sorted unstably Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant