Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error Message for Timestamps Outside Supported Range #5581

Closed
Abdi-29 opened this issue Apr 2, 2024 · 5 comments · Fixed by #5730
Closed

Improve Error Message for Timestamps Outside Supported Range #5581

Abdi-29 opened this issue Apr 2, 2024 · 5 comments · Fixed by #5730
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface parquet Changes to the parquet crate

Comments

@Abdi-29
Copy link
Contributor

Abdi-29 commented Apr 2, 2024

Describe the bug
When executing a query with a timestamp outside the supported range in the arrow cast, users receive a confusing error message about nanosecond overflow. This error message does not clearly explain the limitation of timestamp queries in Datafusion, confusing users.

To Reproduce

  1. Execute a query with a timestamp outside the supported range (e.g., SELECT * FROM t WHERE a < '1650-01-01 01:01:01'::timestamp).

Expected behaviour
I expected to receive a clear error message that explains the limitation of timestamp queries in Datafusion (1677 to 2262) and suggests using timestamps within this range.

Additional context
This issue affects users who query timestamps outside the supported range in the arrow-cast. Improving the error message handling to provide clearer guidance would enhance user experience and reduce confusion.

@Abdi-29 Abdi-29 added the bug label Apr 2, 2024
@Abdi-29
Copy link
Contributor Author

Abdi-29 commented Apr 2, 2024

I did some investigation and the error message is coming from here. I'll be happy working on this issue

@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog and removed bug labels Apr 2, 2024
@tustvold tustvold added the arrow Changes to the arrow crate label Jun 3, 2024
@tustvold
Copy link
Contributor

tustvold commented Jun 3, 2024

label_issue.py automatically added labels {'arrow'} from #5730

@tustvold tustvold added the arrow-flight Changes to the arrow-flight crate label Jun 3, 2024
@tustvold
Copy link
Contributor

tustvold commented Jun 3, 2024

label_issue.py automatically added labels {'arrow-flight'} from #1

@tustvold tustvold added the parquet Changes to the parquet crate label Jun 3, 2024
@tustvold
Copy link
Contributor

tustvold commented Jun 3, 2024

label_issue.py automatically added labels {'parquet'} from #1

@tustvold tustvold added the object-store Object Store Interface label Jun 3, 2024
@tustvold
Copy link
Contributor

tustvold commented Jun 3, 2024

label_issue.py automatically added labels {'object-store'} from #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants