Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more attributes to object_store::Attribute #5689

Closed
netthier opened this issue Apr 25, 2024 · 1 comment · Fixed by #5690
Closed

Add more attributes to object_store::Attribute #5689

netthier opened this issue Apr 25, 2024 · 1 comment · Fixed by #5690
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface

Comments

@netthier
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

I want to set attribute headers currently not included in Attribute but supported by providers such as GCP, AWS and Azure, such as Content-Disposition.

Describe the solution you'd like

More variants should be added to object_store::Attribute and implemented accordingly.
Specifically, I think Content-Disposition, Content-Encoding and Content-Language should be added, as they're well-supported.

Describe alternatives you've considered

It's possible to set the same headers using default headers per-client, but that is unwieldy if one wants to set these headers dynamically.

Additional context

https://cloud.google.com/storage/docs/metadata#content-disposition (and following)
https://learn.microsoft.com/en-us/rest/api/storageservices/put-blob?tabs=microsoft-entra-id#request-headers-all-blob-types
https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObject.html

@netthier netthier added the enhancement Any new improvement worthy of a entry in the changelog label Apr 25, 2024
@tustvold tustvold added the object-store Object Store Interface label May 10, 2024
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'object-store'} from #5690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants