Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure output of MIRI is checked for success #581

Closed
alamb opened this issue Jul 21, 2021 · 0 comments · Fixed by #578
Closed

Ensure output of MIRI is checked for success #581

alamb opened this issue Jul 21, 2021 · 0 comments · Fixed by #578
Labels

Comments

@alamb
Copy link
Contributor

alamb commented Jul 21, 2021

Describe the bug
MIRI tests are run on each CI check but the CI will pass even if the MIRI checks fail

To Reproduce
Introduce a MIRI change and observe CI still passes

Expected behavior
If MIRI fails, CI tests should also fail

Additional context
We started running MIRI again in #421, but while discussing with @jorgecarleitao
on jorgecarleitao/arrow2#209, it turned out that we were still ||true ing the output (aka not validating that MIRA was running cleanly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant