Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why InstanceCredentialProvider::cache is flagged as dead code #5884

Closed
alamb opened this issue Jun 13, 2024 · 1 comment · Fixed by #5888
Closed

Investigate why InstanceCredentialProvider::cache is flagged as dead code #5884

alamb opened this issue Jun 13, 2024 · 1 comment · Fixed by #5888
Labels
bug object-store Object Store Interface

Comments

@alamb
Copy link
Contributor

alamb commented Jun 13, 2024

Describe the bug
In #5883 a new version of Clippy flagged InstanceCredentialProvider::cache as not used

To get CI clean again I disabled the clippy lint, but @Xuanwo rightly suggests we look into the root cause: https://github.com/apache/arrow-rs/pull/5883/files#r1638538556

To Reproduce

Expected behavior
TLDR we should figure out why this was flagged as not used, and either fix the underlying issue or decide that it is not a problem

Additional context

@alamb alamb added bug object-store Object Store Interface labels Jun 13, 2024
@Xuanwo
Copy link
Member

Xuanwo commented Jun 13, 2024

Let me do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug object-store Object Store Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants