Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ObjectStoreScheme in the object_store crate public #5911

Closed
orf opened this issue Jun 18, 2024 · 2 comments · Fixed by #5912
Closed

Make ObjectStoreScheme in the object_store crate public #5911

orf opened this issue Jun 18, 2024 · 2 comments · Fixed by #5912
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface

Comments

@orf
Copy link
Contributor

orf commented Jun 18, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

I want to parse an object store URL into a type. Using parse_url and parse_url_opts casts the result into a Box<dyn ...> which makes it impossible to get the underlying type from.

Describe the solution you'd like

Making ObjectStoreScheme public will allow me to do:

let (scheme, path) = ObjectStoreScheme::parse("s3://foo/bar")
@orf orf added the enhancement Any new improvement worthy of a entry in the changelog label Jun 18, 2024
@drmorr0
Copy link

drmorr0 commented Jun 19, 2024

+1, I want to support all the different cloud providers in my app, but I need more fine-grained control over how the ObjectStore is constructed, so I can't just use parse_url -- having this public would be very useful, I literally just came here to submit a PR to do the same thing :)

@alamb alamb added the object-store Object Store Interface label Jul 2, 2024
@alamb
Copy link
Contributor

alamb commented Jul 2, 2024

label_issue.py automatically added labels {'object-store'} from #5912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants