You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We resolved struct slices by passing the offset and length to child data, but this doesn't work on lists that have struct children, because when slicing lists, we don't pass its offset and length to its child data (a list has 1 child datum). This is because we can calculate this at runtime when indexing into a list.
To Reproduce
Create a list<struct<[int]>> or a map array.
Slice the array
Try to slice into the array
Expected behavior
We should correctly slice into lists of structs, and maps
Describe the bug
We resolved struct slices by passing the offset and length to child data, but this doesn't work on lists that have struct children, because when slicing lists, we don't pass its offset and length to its child data (a list has 1 child datum). This is because we can calculate this at runtime when indexing into a list.
To Reproduce
list<struct<[int]>>
or amap
array.Expected behavior
We should correctly slice into lists of structs, and maps
Additional context
I picked this up while addressing reviews on #491
The text was updated successfully, but these errors were encountered: