Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slicing list<struct<...>> doesn't pass the list offsets to struct children #594

Closed
nevi-me opened this issue Jul 22, 2021 · 1 comment
Closed
Labels

Comments

@nevi-me
Copy link
Contributor

nevi-me commented Jul 22, 2021

Describe the bug

We resolved struct slices by passing the offset and length to child data, but this doesn't work on lists that have struct children, because when slicing lists, we don't pass its offset and length to its child data (a list has 1 child datum). This is because we can calculate this at runtime when indexing into a list.

To Reproduce

  • Create a list<struct<[int]>> or a map array.
  • Slice the array
  • Try to slice into the array

Expected behavior

We should correctly slice into lists of structs, and maps

Additional context

I picked this up while addressing reviews on #491

@tustvold
Copy link
Contributor

tustvold commented Jun 1, 2023

Closed by #4061

@tustvold tustvold closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants