Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use GCE_METADATA_HOST and GCE_METADATA_IP env vars in object_store GCP auth #6014

Closed
barronw opened this issue Jul 7, 2024 · 0 comments · Fixed by #6015
Closed

use GCE_METADATA_HOST and GCE_METADATA_IP env vars in object_store GCP auth #6014

barronw opened this issue Jul 7, 2024 · 0 comments · Fixed by #6015
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface

Comments

@barronw
Copy link
Contributor

barronw commented Jul 7, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

I'm trying to use the GCP integration through a proxy metadata server, but the server host and IP are hardcoded.

Describe the solution you'd like

object_store should check GCE_METADATA_HOST and GCE_METADATA_IP env vars before defaulting to the currently hardcoded values. The Google Python libraries do this (example).

Describe alternatives you've considered

None

Additional context

None
@barronw barronw added the enhancement Any new improvement worthy of a entry in the changelog label Jul 7, 2024
@barronw barronw mentioned this issue Jul 7, 2024
Merged
@alamb alamb added the object-store Object Store Interface label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use GCE metadata server env var overrides
2 participants
@alamb @barronw