Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove undefined behavior in value method of boolean and primitive arrays #645

Closed
Dandandan opened this issue Jul 31, 2021 · 0 comments · Fixed by #644
Closed

Remove undefined behavior in value method of boolean and primitive arrays #645

Dandandan opened this issue Jul 31, 2021 · 0 comments · Fixed by #644
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@Dandandan
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
As they OOB check uses debug_assert instead of assert, the check is not there in release mode.
We should use assert! instead.

Describe the solution you'd like
We should use assert! instead. In places where value is used directly and can be converted to use the unchecked variant, we can do so.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@Dandandan Dandandan added the enhancement Any new improvement worthy of a entry in the changelog label Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant