Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve page index metadata loading in SerializedFileReader::new_with_options #6491

Closed
alamb opened this issue Oct 1, 2024 · 3 comments · Fixed by #6506
Closed

Improve page index metadata loading in SerializedFileReader::new_with_options #6491

alamb opened this issue Oct 1, 2024 · 3 comments · Fixed by #6506
Assignees
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@alamb
Copy link
Contributor

alamb commented Oct 1, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
As @etseidl pointed out in https://github.com/apache/arrow-rs/pull/6466/files#r1778966728

This should be a bit more efficient since read_page_indexes will fetch the necessary bytes from the file in a single read, rather than 2 reads per row group.

We can use the new ParquetMetaDataLoader API to read the page indexes in more efficiently (fewer IOs for example)

However, when I tried to implement it, we caught what appears to be a subtle bug -- specifically that the predicates would have been ignored: https://github.com/apache/arrow-rs/pull/6466/files#r1783526090 -- no tests failed.

Describe the solution you'd like

I would like to:

  1. Reduce the IO's needed to read page indexes in SerializedFileReader::new_with_options, and clean up the code to use the new ParquetMetaDataReader
  2. Add test coverage for reader predicates and page index

Describe alternatives you've considered
leave as is

Additional context

@alamb alamb added enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate labels Oct 1, 2024
@etseidl
Copy link
Contributor

etseidl commented Oct 2, 2024

@alamb are you working on this or would you like me to take it?

@alamb
Copy link
Contributor Author

alamb commented Oct 3, 2024

@alamb are you working on this or would you like me to take it?

I am not planning to work on this at this time. If you had time to look at it that would be great.

THank you 🙏

@etseidl
Copy link
Contributor

etseidl commented Oct 3, 2024

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
2 participants