Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parquet crate 5.2 does not compile #695

Closed
ritchie46 opened this issue Aug 17, 2021 · 1 comment
Closed

parquet crate 5.2 does not compile #695

ritchie46 opened this issue Aug 17, 2021 · 1 comment
Labels

Comments

@ritchie46
Copy link
Contributor

Cargo.toml

[dependencies]
arrow = {version = "5.2", default-features = false }
parquet = {version = "5.2", default-features = false }

Output

cargo check

   --> /home/ritchie46/.cargo/registry/src/github.com-1ecc6299db9ec823/parquet-5.2.0/src/data_type.rs:591:9
    |
591 |     use arrow::util::bit_util::round_upto_power_of_2;
    |         ^^^^^ use of undeclared crate or module `arrow`

error[E0433]: failed to resolve: use of undeclared crate or module `arrow`
  --> /home/ritchie46/.cargo/registry/src/github.com-1ecc6299db9ec823/parquet-5.2.0/src/util/test_common/file_util.rs:23:28
   |
23 |         PathBuf::from_str(&arrow::util::test_util::parquet_test_data()).unwrap();
   |                            ^^^^^ use of undeclared crate or module `arrow`

error[E0425]: cannot find function `round_upto_power_of_2` in this scope
   --> /home/ritchie46/.cargo/registry/src/github.com-1ecc6299db9ec823/parquet-5.2.0/src/data_type.rs:677:36
    |
677 |                 let bytes_needed = round_upto_power_of_2(bytes_needed, 256);
    |                                    ^^^^^^^^^^^^^^^^^^^^^ not found in this scope

Some errors have detailed explanations: E0425, E0433.
For more information about an error, try `rustc --explain E0425`.
error: could not compile `parquet` due to 3 previous errors

Is this related to #690? If not, I really think we should run combinations of feature gates in CI, as these bugs are easy to prevent.

@ritchie46 ritchie46 added the bug label Aug 17, 2021
@alamb
Copy link
Contributor

alamb commented Jul 23, 2022

I tried this with the most recent parquet release 18.0.0:


[dependencies]
arrow = {version = "18.0.0", default-features = false }
parquet = {version = "18.0.0", default-features = false }

And it works. I am not sure when we fixed it but I think we are all good now

@alamb alamb closed this as completed Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants