We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenericBytesView
This is something I also noticed in #7082
One thing to note is that NullBufferBuilder::allocated_size() is used here:
NullBufferBuilder::allocated_size()
arrow-rs/arrow-array/src/builder/generic_bytes_view_builder.rs
Lines 397 to 408 in 92cfd99
And I think it's used with assumption it provides bytes not bits, so may need adjustment.
Originally posted by @Jefffrey in #7089 (review)
I think the adjustment is to divide the allocated_size by 8.
Another solution would be to deprecate allocated_size entirely and make a new function that returns allocated size in bytes
The text was updated successfully, but these errors were encountered:
NullBufferBuilder::allocated_size
Successfully merging a pull request may close this issue.
One thing to note is that
NullBufferBuilder::allocated_size()
is used here:arrow-rs/arrow-array/src/builder/generic_bytes_view_builder.rs
Lines 397 to 408 in 92cfd99
And I think it's used with assumption it provides bytes not bits, so may need adjustment.
Originally posted by @Jefffrey in #7089 (review)
I think the adjustment is to divide the allocated_size by 8.
Another solution would be to deprecate allocated_size entirely and make a new function that returns allocated size in bytes
The text was updated successfully, but these errors were encountered: