Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array data imported through the FFI might contain unaligned buffers #7136

Open
felipecrv opened this issue Feb 15, 2025 · 1 comment · May be fixed by #7137
Open

Array data imported through the FFI might contain unaligned buffers #7136

felipecrv opened this issue Feb 15, 2025 · 1 comment · May be fixed by #7137
Assignees
@felipecrv
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@felipecrv
Copy link
Contributor

Describe the bug

I described the issue in detail on the arrow-adbc bug tracker:

apache/arrow-adbc#2526

To Reproduce

Executing a query through the Snowflake ADBC driver (Go) that happens to produce array with unaligned buffers. The linked issue above contains a stack trace.

Expected behavior

The Rust code importing the array should check the alignment and copy the buffers to an unaligned position if necessary.
@felipecrv felipecrv added the bug label Feb 15, 2025
@felipecrv felipecrv self-assigned this Feb 15, 2025
@felipecrv felipecrv linked a pull request Feb 15, 2025 that will close this issue
Open
@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog and removed bug labels Feb 15, 2025
@tustvold
Copy link
Contributor

Changing this to an enhancement, as the current behaviour is intentional, even if it could be improved (e.g. returning an error instead of panicking). It would be a bug if buffer misalignment was not being caught (i.e. UB).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipecrv felipecrv

Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align buffers of array data imported through the FFI if they aren't aligned felipecrv/arrow-rs
2 participants
@felipecrv @tustvold