Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support equality on RecordBatch #735

Closed
bjchambers opened this issue Sep 1, 2021 · 1 comment · Fixed by #750
Closed

Support equality on RecordBatch #735

bjchambers opened this issue Sep 1, 2021 · 1 comment · Fixed by #750
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@bjchambers
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

This would simplify testing. Right now, if I have two record batches that I want to test for equality I need to either look at their individual columns, or convert the batch to a StructArray.

Describe the solution you'd like

It seems like we should be able to implement PartialEq (and possibly Eq) for RecordBatch to perform equality on the schema and columns.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@bjchambers bjchambers added the enhancement Any new improvement worthy of a entry in the changelog label Sep 1, 2021
@matthewmturner
Copy link
Contributor

@bjchambers I can give this a shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants