Skip to content

Conversation

@vegarsti
Copy link
Contributor

@vegarsti vegarsti commented Oct 27, 2025

Related to #8707.

Inspired by #8716 (comment), a follow up improvement to #8589: We already know what the length of the two vectors will be, so we can create them with that capacity.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Oct 27, 2025
@vegarsti vegarsti changed the title perf: Reduce allocations in cast_to_run_end_encoded perf: Use vec::with_capacity in cast_to_run_end_encoded Oct 28, 2025
@vegarsti vegarsti changed the title perf: Use vec::with_capacity in cast_to_run_end_encoded perf: Use Vec::with_capacity in cast_to_run_end_encoded Oct 28, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vegarsti

Copy link
Member

@Weijun-H Weijun-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! Thanks @vegarsti 👍

@alamb alamb merged commit 2eabb59 into apache:main Oct 30, 2025
26 checks passed
@alamb
Copy link
Contributor

alamb commented Oct 30, 2025

Thanks again @vegarsti and @Weijun-H

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants