Set specVersion in toThrift

Author: sfc-gh-aixu

cpp/src/generated/parquet_types.cpp

@@ -410,7 +410,7 @@ struct BsonType {
 struct VariantType {
   // The version of the variant specification that the variant was
   // written with.
-  1: optional i8 specification_version = 1
+  1: optional i8 specification_version
 }
 
 /** Edge interpolation algorithm for Geography logical type */

cpp/src/generated/parquet_types.h

@@ -2357,11 +2357,12 @@ TEST(TestLogicalTypeSerialization, Roundtrips) {
 }
 
 TEST(TestLogicalTypeSerialization, VariantSpecificationVersion) {
-  // Confirm that Variant logical type sets specification_version to 1 in thrift serialization
+  // Confirm that Variant logical type sets specification_version to 1 in thrift
+  // serialization
   auto metadata = PrimitiveNode::Make("metadata", Repetition::REQUIRED, Type::BYTE_ARRAY);
   auto value = PrimitiveNode::Make("value", Repetition::REQUIRED, Type::BYTE_ARRAY);
-  NodePtr variant_node = GroupNode::Make("variant", Repetition::REQUIRED, {metadata, value},
-                                         LogicalType::Variant());
+  NodePtr variant_node = GroupNode::Make("variant", Repetition::REQUIRED,
+                                         {metadata, value}, LogicalType::Variant());
 
   std::vector<format::SchemaElement> elements;
   ToParquet(reinterpret_cast<GroupNode*>(variant_node.get()), &elements);

cpp/src/parquet/parquet.thrift

@@ -1959,12 +1959,20 @@ class LogicalType::Impl::Variant final : public LogicalType::Impl::Incompatible,
   friend class VariantLogicalType;
 
   OVERRIDE_TOSTRING(Variant)
-  OVERRIDE_TOTHRIFT(VariantType, VARIANT)
+
+  format::LogicalType ToThrift() const override {
+    format::LogicalType type;
+    format::VariantType variant_type;
+    variant_type.__set_specification_version(kSpecificationVersion);
+    type.__set_VARIANT(variant_type);
+    return type;
+  }
 
  private:
   Variant()
       : LogicalType::Impl(LogicalType::Type::VARIANT, SortOrder::UNKNOWN),
         LogicalType::Impl::Inapplicable() {}
+  static constexpr int8_t kSpecificationVersion = 1;
 };
 
 GENERATE_MAKE(Variant)