Minor clean-up

Author: raulcd

cpp/cmake_modules/ThirdpartyToolchain.cmake

@@ -2862,20 +2862,14 @@ function(build_re2)
   # Unity build causes some build errors
   set(CMAKE_UNITY_BUILD OFF)
 
-  # ATTEMPT #7: Prevent RE2 from adding install() commands
-  message(STATUS "ATTEMPT #7: Using CMAKE_SKIP_INSTALL_RULES to disable RE2 install")
-  set(_arrow_skip_install_rules ${CMAKE_SKIP_INSTALL_RULES})
+  # Disable install rules for RE2 so it is not installed on our Linux-packages.
   set(CMAKE_SKIP_INSTALL_RULES ON)
 
   fetchcontent_makeavailable(re2)
 
-  # Restore the original value
-  set(CMAKE_SKIP_INSTALL_RULES ${_arrow_skip_install_rules})
-
-  # Create an empty cmake_install.cmake so include() doesn't fail
+  # We have to create an empty cmake_install.cmake so include() doesn't fail but doesn't install anything.
   file(WRITE "${re2_BINARY_DIR}/cmake_install.cmake"
        "# RE2 install disabled via CMAKE_SKIP_INSTALL_RULES\n")
-  message(STATUS "Created empty cmake_install.cmake for RE2")
 
   set(ARROW_BUNDLED_STATIC_LIBS
       ${ARROW_BUNDLED_STATIC_LIBS} re2::re2
@@ -3227,7 +3221,7 @@ function(build_grpc)
         "$<TARGET_FILE:protobuf::protoc>"
         CACHE STRING "" FORCE)
 
-    # gRPC needs this at configure time for add_custom_command.
+    # gRPC needs this at configure time.
     get_filename_component(_protobuf_root_dir "${protobuf_SOURCE_DIR}" DIRECTORY)
     set(_gRPC_PROTOBUF_WELLKNOWN_INCLUDE_DIR
         "${_protobuf_root_dir}/src"
@@ -3270,23 +3264,16 @@ function(build_grpc)
            " -Wno-attributes -Wno-format-security -Wno-unknown-warning-option")
   endif()
 
-  # ATTEMPT #7: Prevent gRPC from adding install() commands by setting CMAKE_SKIP_INSTALL_RULES
-  # This must be set BEFORE fetchcontent_makeavailable processes gRPC's CMakeLists.txt
-  message(STATUS "ATTEMPT #7: Using CMAKE_SKIP_INSTALL_RULES to disable gRPC install")
-  set(_arrow_skip_install_rules ${CMAKE_SKIP_INSTALL_RULES})
+  # Disable install rules for gRPC so it is not installed on our Linux-packages.
   set(CMAKE_SKIP_INSTALL_RULES ON)
 
   fetchcontent_makeavailable(grpc)
 
-  # Restore the original value so Arrow's install rules still work
-  set(CMAKE_SKIP_INSTALL_RULES ${_arrow_skip_install_rules})
-
   # CMAKE_SKIP_INSTALL_RULES prevents cmake_install.cmake from being created,
   # but the parent cmake_install.cmake still tries to include() it.
   # Create an empty one manually so include() doesn't fail.
   file(WRITE "${grpc_BINARY_DIR}/cmake_install.cmake"
        "# gRPC install disabled via CMAKE_SKIP_INSTALL_RULES\n")
-  message(STATUS "Created empty cmake_install.cmake for gRPC")
 
   # FetchContent builds gRPC libraries without gRPC:: prefix.
   # Create gRPC:: alias targets for consistency.