Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: plasma tests failing in conda builds on linux #15015

Closed
h-vetinari opened this issue Dec 18, 2022 · 2 comments
Closed

BUG: plasma tests failing in conda builds on linux #15015

h-vetinari opened this issue Dec 18, 2022 · 2 comments

Comments

@h-vetinari
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

#14832 switched on the test suite within the conda-builds, which itself synced with conda-forge/arrow-cpp-feedstock#875

In the process of doing so, currently all tests starting with test_plasma in their name were skipped,

# vvvvvvv TESTS THAT SHOULDN'T HAVE TO BE SKIPPED vvvvvvv
# failing on linux with "OSError: Could not connect to socket /tmp/[...]/plasma.sock"
{% set tests_to_skip = tests_to_skip + " or test_plasma" %} # [linux]

This only fails on linux, not on osx (windows doesn't have plasma). Additionally, it seems that there are two binaries for plasma-store-server being installed, one in $PREFIX/bin and one in $PREFIX/lib/python3.x/site-packages/pyarrow/. I'm pretty sure this is a left-over from making libarrow python-independent?

To fix this, the line quoted above should be removed, and the conda-linux tests still pass. Ideally, there should only be one plasma-store-server binary being installed.

Component(s)

C++ - Plasma

@kou
Copy link
Member

kou commented Dec 18, 2022

I'm pretty sure this is a left-over from making libarrow python-independent?

This is not related. $PREFIX/lib/python3.x/site-packages/pyarrow/plasma-store-server is for users who don't have system Apache Arrow C++. (For example, pyarrow wheel users.)

We can stop installing $PREFIX/lib/python3.x/site-packages/pyarrow/plasma-store-server by the following:

diff --git a/dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh b/dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh
old mode 100644
new mode 100755
index 692ffb7806..98c0fa9181
--- a/dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh
+++ b/dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh
@@ -9,6 +9,7 @@ export PARQUET_HOME=$PREFIX
 export SETUPTOOLS_SCM_PRETEND_VERSION=$PKG_VERSION
 export PYARROW_BUILD_TYPE=release
 export PYARROW_BUNDLE_ARROW_CPP_HEADERS=0
+export PYARROW_BUNDLE_PLASMA_EXECUTABLE=0
 export PYARROW_WITH_DATASET=1
 export PYARROW_WITH_FLIGHT=1
 export PYARROW_WITH_GANDIVA=1

See also:

@h-vetinari
Copy link
Contributor Author

Since plasma got removed, I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants