Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Usage of Hash Aggregation #15162

Closed
ava6969 opened this issue Jan 2, 2023 · 2 comments
Closed

[C++] Usage of Hash Aggregation #15162

ava6969 opened this issue Jan 2, 2023 · 2 comments
Labels
Component: C++ Type: usage Issue is a user question

Comments

@ava6969
Copy link

ava6969 commented Jan 2, 2023

Describe the usage question you have. Please include as many useful details as possible.

I am still confused on the right way to use the hash aggregations. I found 3 different approaches in the hash_aggregation_test.cc which included a naive grouper/exec_plan and internal group_by. Is anyone particularly recommended as GroupBy is used in the python api but the doc said its not for public use.

Component(s)

C++

@ava6969 ava6969 added the Type: usage Issue is a user question label Jan 2, 2023
@AlenkaF AlenkaF changed the title Usage of Hash Aggregation [C++] Usage of Hash Aggregation Jan 3, 2023
@westonpace
Copy link
Member

My opinion is that the correct approach should be to use an exec plan. Pyarrow perhaps uses internal::GroupBy because it finds the API more convenient but it was never intended to be a long term thing.

I have a PR (#14867) to adapt the internal::GroupBy API to using an exec plan under the hood for those that find that API more convenient. However, this PR is not yet merged.

@ava6969
Copy link
Author

ava6969 commented Jan 4, 2023

Thanks for your clarification i'll check it out.

@ava6969 ava6969 closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: C++ Type: usage Issue is a user question
Projects
None yet
Development

No branches or pull requests

3 participants