-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Refactor hash table support #15725
Comments
Wes McKinney / @wesm: Luckily, we have plenty of other hash table implementations in other projects to look at to see how efficient our implementations are relative to comparables |
Antoine Pitrou / @pitrou: |
Wes McKinney / @wesm: |
Antoine Pitrou / @pitrou: |
Antoine Pitrou / @pitrou: |
Wes McKinney / @wesm: |
Currently our hash table support is scattered in several places:
compute/kernels/hash.cc
util/hash.h
andutil/hash.cc
builder.cc
(in the DictionaryBuilder implementation)Perhaps we should have something like a type-parametered hash table class (perhaps backed by non-owned memory) with several primitives:
decide allocation size for a given number of items
lookup an item
insert an item
decide whether resizing is needed
resize to a new memory area
...
Reporter: Antoine Pitrou / @pitrou
Assignee: Antoine Pitrou / @pitrou
Related issues:
PRs and other links:
Note: This issue was originally created as ARROW-2653. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: