Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Update developing.Rmd vignette #29073

Closed
Tracked by #29076
asfimport opened this issue Jul 20, 2021 · 1 comment
Closed
Tracked by #29076

[R] Update developing.Rmd vignette #29073

asfimport opened this issue Jul 20, 2021 · 1 comment
Assignees
Milestone

Comments

@asfimport
Copy link
Collaborator

Proposed changes:

  • Make the subheadings in "developer environment" setup match the steps in the numbered bullets
  • "at a specific ref" -> clarify
  • include reference table of environment variables??
  • add flowchart to " What happens when you R CMD INSTALL?" section?
  • "so the installation process is easy" - rephrase from "is easy" to something that acknowledges it's only easy when it goes right!
  • "it should look incredibly familiar" - rephase from "should" to "might" or similar
  • Add something about the fact that we use tidyverse style and recommend styling code with styler

Reporter: Nicola Crane / @thisisnic
Assignee: Nicola Crane / @thisisnic

PRs and other links:

Note: This issue was originally created as ARROW-13403. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Jonathan Keane / @jonkeane:
Issue resolved by pull request 10930
#10930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants