Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Add tests to consider an empty chunked array for Arrow::Table#each_raw_records #37561

Open
otegami opened this issue Sep 5, 2023 · 4 comments

Comments

@otegami
Copy link
Contributor

otegami commented Sep 5, 2023

Describe the enhancement requested

Some test cases currently couldn't consider an empty chunked array.
So we should add this test pattern to the other test cases about Arrow::Table#each_raw_records like the following.

record_batch = Arrow::RecordBatch.new(schema, records)
# Multiple chunks
record_batches = [
record_batch.slice(0, 2),
record_batch.slice(2, 0), # Empty chunk
record_batch.slice(2, record_batch.length - 2),
]
Arrow::Table.new(schema, record_batches)

Component(s)

Ruby

@otegami otegami changed the title Add tests to consider an empty chunked array for Arrow::Table#each_raw_records [Ruby] Add tests to consider an empty chunked array for Arrow::Table#each_raw_records Sep 5, 2023
@otegami
Copy link
Contributor Author

otegami commented Sep 6, 2023

I will take it!

@kou
Copy link
Member

kou commented Sep 6, 2023

You need to use just "take": https://arrow.apache.org/docs/dev/developers/bug_reports.html#issue-assignment

@otegami
Copy link
Contributor Author

otegami commented Sep 6, 2023

Ahhh thank you🙏🏽

@otegami
Copy link
Contributor Author

otegami commented Sep 6, 2023

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants