Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packaging] soversion bumps on minor releases #41659

Closed
jtanx opened this issue May 15, 2024 · 8 comments
Closed

[Packaging] soversion bumps on minor releases #41659

jtanx opened this issue May 15, 2024 · 8 comments
Labels
Component: Python Type: usage Issue is a user question

Comments

@jtanx
Copy link

jtanx commented May 15, 2024

Describe the usage question you have. Please include as many useful details as possible.

Hi, the latest release of pyarrow bumps the soversion to 1601. It's painful enough that the soversion bumps with every major release, but is there a need to bump the soversion on minor releases? Are breaking abi changes really being released on minor releases?

Component(s)

Python

@jtanx jtanx added the Type: usage Issue is a user question label May 15, 2024
@kou
Copy link
Member

kou commented May 16, 2024

@pitrou What do you think about this? FYI: #4801 for the current versioning schema.

@pitrou
Copy link
Member

pitrou commented May 16, 2024

We're not supposed to break the ABI in bugfix releases, so I don't know why the soversion was bumped.

@jorisvandenbossche
Copy link
Member

The latest 16.1.0 release was not a bug-fix release, but a minor / feature release, though (and the first time we ever did this since 1.0, AFAIK, so I don't know if we have explicit expectations around this, I personally would expect that a feature release is not ABI stable)

@pitrou
Copy link
Member

pitrou commented May 16, 2024

Ah, right. Well, 16.1.0 is a slightly unusual case then.

@jtanx
Copy link
Author

jtanx commented May 16, 2024

Imo if this is going to be a breaking abi change it might as well be a major version bump

@jorisvandenbossche jorisvandenbossche changed the title soversion bumps on minor releases [Packaging] soversion bumps on minor releases May 17, 2024
@jorisvandenbossche
Copy link
Member

To be clear, we explicitly decided to bump the so version for minor feature releases at the time of the first 1.0.0 release. See this issue Kou linked above (#4801) and this email thread: https://lists.apache.org/thread/r1ztq38xz5tn4p4v0xc1xk2d8x82p84v)

@jorisvandenbossche
Copy link
Member

I opened an issue about that we need to better document the expectations: #41707

@jorisvandenbossche
Copy link
Member

Let's close this in favor of discussing it further in #41707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Python Type: usage Issue is a user question
Projects
None yet
Development

No branches or pull requests

4 participants