Skip to content

GH-47088: [CI][Dev] Fix shellcheck errors in the ci/scripts/integration_arrow.sh #47089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 2 commits into from
Jul 15, 2025
Merged

GH-47088: [CI][Dev] Fix shellcheck errors in the ci/scripts/integration_arrow.sh #47089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94b8b1e
GH-47088: [CI][Dev] Fix shellcheck errors in the ci/scripts/integrati…
hiroyuki-sato Jul 12, 2025
c3693f8
GH-47088: [CI][Dev] Fix shellcheck errors in the ci/scripts/integrati…
hiroyuki-sato Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,7 @@ repos:
?^ci/scripts/install_spark\.sh$|
?^ci/scripts/install_vcpkg\.sh$|
?^ci/scripts/integration_arrow_build\.sh$|
?^ci/scripts/integration_arrow\.sh$|
?^ci/scripts/integration_dask\.sh$|
?^ci/scripts/integration_spark\.sh$|
?^ci/scripts/matlab_build\.sh$|
Expand Down
29 changes: 16 additions & 13 deletions ci/scripts/integration_arrow.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@ build_dir=${2}

gold_dir=$arrow_dir/testing/data/arrow-ipc-stream/integration

: ${ARROW_INTEGRATION_CPP:=ON}
: ${ARROW_INTEGRATION_CSHARP:=ON}
: "${ARROW_INTEGRATION_CPP:=ON}"
: "${ARROW_INTEGRATION_CSHARP:=ON}"

: ${ARCHERY_INTEGRATION_TARGET_IMPLEMENTATIONS:=cpp,csharp}
: "${ARCHERY_INTEGRATION_TARGET_IMPLEMENTATIONS:=cpp,csharp}"
export ARCHERY_INTEGRATION_TARGET_IMPLEMENTATIONS

. ${arrow_dir}/ci/scripts/util_log.sh
. "${arrow_dir}/ci/scripts/util_log.sh"

github_actions_group_begin "Integration: Prepare: Archery"
pip install -e $arrow_dir/dev/archery[integration]
pip install -e "$arrow_dir/dev/archery[integration]"
github_actions_group_end

github_actions_group_begin "Integration: Prepare: Dependencies"
Expand All @@ -58,16 +58,19 @@ export PYTHONFAULTHANDLER=1
export GOMEMLIMIT=200MiB
export GODEBUG=gctrace=1,clobberfree=1

ARCHERY_WITH_CPP=$([ "$ARROW_INTEGRATION_CPP" == "ON" ] && echo "1" || echo "0")
ARCHERY_WITH_CSHARP=$([ "$ARROW_INTEGRATION_CSHARP" == "ON" ] && echo "1" || echo "0")

# Rust can be enabled by exporting ARCHERY_INTEGRATION_WITH_RUST=1
time archery integration \
--run-c-data \
--run-ipc \
--run-flight \
--with-cpp=$([ "$ARROW_INTEGRATION_CPP" == "ON" ] && echo "1" || echo "0") \
--with-csharp=$([ "$ARROW_INTEGRATION_CSHARP" == "ON" ] && echo "1" || echo "0") \
--gold-dirs=$gold_dir/0.14.1 \
--gold-dirs=$gold_dir/0.17.1 \
--gold-dirs=$gold_dir/1.0.0-bigendian \
--gold-dirs=$gold_dir/1.0.0-littleendian \
--gold-dirs=$gold_dir/2.0.0-compression \
--gold-dirs=$gold_dir/4.0.0-shareddict \
--with-cpp="${ARCHERY_WITH_CPP}" \
--with-csharp="${ARCHERY_WITH_CSHARP}"\
--gold-dirs="$gold_dir/0.14.1" \
--gold-dirs="$gold_dir/0.17.1" \
--gold-dirs="$gold_dir/1.0.0-bigendian" \
--gold-dirs="$gold_dir/1.0.0-littleendian" \
--gold-dirs="$gold_dir/2.0.0-compression" \
--gold-dirs="$gold_dir/4.0.0-shareddict" \
Loading