Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: BigQuery table name validation doesn't allow spaces #21878

Closed
zchenyu opened this issue Jun 15, 2022 · 3 comments
Closed

[Bug]: BigQuery table name validation doesn't allow spaces #21878

zchenyu opened this issue Jun 15, 2022 · 3 comments

Comments

@zchenyu
Copy link

zchenyu commented Jun 15, 2022

What happened?

BigQuery IO currently rejects table names that contain spaces.

From https://cloud.google.com/bigquery/docs/tables#table_naming : a table name can contain spaces.

Looks like it will require an update to this regex:

r'^((?P<project>.+):)?(?P<dataset>\w+)\.(?P<table>[-\w\$]+)$', table)

Similar to this PR which allowed - in table names: #14125

Issue Priority

Priority: 2

Issue Component

Component: io-py-gcp

@yeandy
Copy link
Contributor

yeandy commented Jun 23, 2022

@BjornPrime This has intersections with I/O, but this could be a good starter bug to get you used to the workflow of testing, making a PR, etc.

@dgdheeraj
Copy link
Contributor

.take-issue

@shhivam
Copy link
Contributor

shhivam commented Jul 22, 2022

@dgdheeraj has kindly made a PR for this and that PR is merged.

Think we can close this issue? @damccorm @kennknowles @yeandy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants