Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Firestore Connector can have empty cursors resulting in an incorrect success #22089

Closed
alexbeltran opened this issue Jun 28, 2022 · 1 comment

Comments

@alexbeltran
Copy link

What happened?

Reproduction Steps:

  1. Have a sufficiently large RunQuery that times out
  2. Run query
  3. The Connector terminates after timeout but returns a success.

This is likely due to, https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreV1ReadFn.java#L426 which uses a last received value to get a start point. There is no error check so the last received value may be empty. From there an empty cursor is created.

Issue Priority

Priority: 2

Issue Component

Component: io-java-gcp

@chamikaramj
Copy link
Contributor

Fixed by #22175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants