Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task][Go SDK]: Utility function for inferring field names based on struct tags #24465

Closed
johannaojeling opened this issue Dec 1, 2022 · 1 comment · Fixed by #24473
Closed
Assignees
Labels
done & done Issue has been reviewed after it was closed for verification, followups, etc. go P2 task

Comments

@johannaojeling
Copy link
Contributor

What needs to happen?

There is a TODO in the bigqueryio.Read transform to infer column names from type t instead of using SELECT * in the query.

I would like a function, e.g. in the util package, which infers field names from a given struct type and tag key, and returns them as a []string.

It can be used in bigqueryio.Read to construct the select statement and for similar use cases, such as in spannerio.Read which currently uses its own unexported columnsFromStruct function.

Issue Priority

Priority: 2

Issue Component

Component: sdk-go

@johannaojeling
Copy link
Contributor Author

.take-issue

@github-actions github-actions bot added this to the 2.45.0 Release milestone Dec 2, 2022
@lostluck lostluck added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done & done Issue has been reviewed after it was closed for verification, followups, etc. go P2 task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants