Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump snappy-java version to 1.1.10.4 #28655

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

bvolpato
Copy link
Contributor

Upgrade due to GitHub security advisory: GHSA-55g7-9cwv-5qfv

@github-actions github-actions bot added the build label Sep 25, 2023
@bvolpato
Copy link
Contributor Author

beam_PreCommit_Java_Amazon-Web-Services2_IO_Direct

@bvolpato
Copy link
Contributor Author

Run Java_Pulsar_IO_Direct

@bvolpato
Copy link
Contributor Author

Run Java_Amazon-Web-Services_IO_Direct PreCommit

@bvolpato
Copy link
Contributor Author

Run Java_Amazon-Web-Services2_IO_Direct PreCommit

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #28655 (a55adaa) into master (fd0527a) will increase coverage by 0.00%.
Report is 119 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #28655   +/-   ##
=======================================
  Coverage   72.20%   72.20%           
=======================================
  Files         684      684           
  Lines      101141   101141           
=======================================
+ Hits        73029    73030    +1     
+ Misses      26534    26533    -1     
  Partials     1578     1578           
Flag Coverage Δ
python 82.75% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@bvolpato
Copy link
Contributor Author

bvolpato commented Oct 6, 2023

Run Java_Pulsar_IO_Direct PreCommit

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn Abacn merged commit bd46c76 into apache:master Oct 11, 2023
52 checks passed
@damccorm
Copy link
Contributor

Noting that this surprisingly ended up being a backwards incompatible change since it changed the serialized form of the SnappyCoder so now anything which uses SnappyCoder can't be upgraded from <=2.51.0 to >=2.52.0. I noticed this in PubSub read.

@damccorm
Copy link
Contributor

Documenting this in #32753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants