Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dataflow Example Java11/17 PreCommits actually running on Java 8 container #29168

Closed
1 of 16 tasks
Abacn opened this issue Oct 27, 2023 · 1 comment · Fixed by #29170
Closed
1 of 16 tasks

[Bug]: Dataflow Example Java11/17 PreCommits actually running on Java 8 container #29168

Abacn opened this issue Oct 27, 2023 · 1 comment · Fixed by #29170

Comments

@Abacn
Copy link
Contributor

Abacn commented Oct 27, 2023

What happened?

It has puzzled me when doing #28967, after compiling the example with Java11/17, Dataflow gives unsupported Java version error. Digging into the log one can see

Downloaded container image us-central1-artifactregistry.gcr.io/google.com/dataflow-containers/worker/v1beta3/beam-java-streaming:20231008-20-rc00 checksummed successfully.

which means a Java 8 container is used, even though the test is running on Java17 and the latest dev container version is 20231026

It has been working so far because currently the examples are still compiled on Java8, and the test (compile and submitted by Java17) is only a thin wrapper of the former

Issue Priority

Priority: 2 (default / most bugs should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@Abacn
Copy link
Contributor Author

Abacn commented Oct 27, 2023

Found that the cause is here:

"--workerHarnessContainerImage=${actualWorkerHarnessContainerImage}"

It assigns an empty string to workerHarnessContainerImage pipeline option. This has caused Dataflow to use an old container in us-central1-docker.pkg.dev/google.com/dataflow-containers/worker/v1beta3/beam-java-streaming

This might be an internal bug. Removing this line, the tag for container is determined by

ext.dataflowLegacyContainerVersion = 'beam-master-20231026'

and is using correct java version now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant