Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace StateTag.StateBinder to top level StateBinder in SparkStateInternals #31798

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

twosom
Copy link
Contributor

@twosom twosom commented Jul 8, 2024

Please add a meaningful description for your change here

fixes #31797

This PR contains theses changes

  • replace StateTag.StateBinder to top level StateBinder in SparkStateInternals
  • modify StateTag.StateBinder doc for link top level StateBinder (org.apache.beam.sdk.state.StateBinder)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@twosom twosom changed the title Replace state tag to top level Replace StateTag.StateBinder to top level StateBinder in SparkStateInternals Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @shunping added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

Reminder, please take a look at this pr: @shunping

Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @shunping added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@kennknowles
Copy link
Member

LGTM but probably worth touching some validates runner files in .github/trigger_files/ for Spark.

@twosom
Copy link
Contributor Author

twosom commented Jul 19, 2024

LGTM but probably worth touching some validates runner files in .github/trigger_files/ for Spark.

Thank you for comment. I'll touch trigger_files and validate Spark Runner! 😊

@github-actions github-actions bot added build and removed build labels Jul 19, 2024
Copy link
Contributor

Reminder, please take a look at this pr: @shunping

Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @shunping added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@twosom
Copy link
Contributor Author

twosom commented Aug 5, 2024

@kennknowles
Please advise if there are any further issues that require attention.
Thank you.

@kennknowles kennknowles merged commit 780eef9 into apache:master Aug 12, 2024
24 checks passed
lostluck pushed a commit to lostluck/beam that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Replace deprecated StateTag.StateBinder in SparkStateInternals.
2 participants