Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for the TOKENLIST type in Spanner #32038

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

atask-g
Copy link
Contributor

@atask-g atask-g commented Jul 31, 2024

Extended the SpannerSchema.Column class to be able to parse a Spanner TOKENLIST typed column. This is needed to support search indexes in Teleport.
R: @darshan-sj

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @chamikaramj for label io.
R: @nielm for label spanner.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@atask-g
Copy link
Contributor Author

atask-g commented Aug 2, 2024

R: @darshan-sj

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@chamikaramj
Copy link
Contributor

Can we add a test ?

Copy link
Contributor

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abacn Abacn merged commit d09c323 into apache:master Aug 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants