Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: BigtableIO integration tests not actually testing #32071

Open
17 tasks
Abacn opened this issue Aug 3, 2024 · 0 comments
Open
17 tasks

[Bug]: BigtableIO integration tests not actually testing #32071

Abacn opened this issue Aug 3, 2024 · 0 comments

Comments

@Abacn
Copy link
Contributor

Abacn commented Aug 3, 2024

What happened?

BigtableReadIT and BigtableWriteIT are written incorrectly. Firstly, instead of using a TestPipeline, it first get the PipelineOptions from TestPipeline.testingPipelineOptions() in @Before setup(), then assemble a normal Pipeline and calls Pipeline.run(). This has a couple of problems

  • It does not check if pipeline failed. Actually, testE2EBigtableSegmentRead has been consistently failing on Direct Runner due to OOM. It was until Add Lineage metrics for BigtableIO #32068 tries to assert Lineage metrics found that the pipeline actually failed and did not report the metrics

  • on Dataflow runner, pipeline.run() is non-blocking, the test just submit a pipeline and ends

Issue Priority

Priority: 2 (default / most bugs should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Infrastructure
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant