Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prism] Enable artifact staging during Prism Runner lifecycle #32084

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

damondouglas
Copy link
Contributor

This PR closes #32055 enabling artifact staging for the Prism runner.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damondouglas damondouglas marked this pull request as ready for review August 5, 2024 17:30
@damondouglas
Copy link
Contributor Author

R: @ahmedabu98 would you mind to review? Thank you.

@damondouglas damondouglas marked this pull request as draft August 5, 2024 17:31
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@damondouglas
Copy link
Contributor Author

@ahmedabu98 I need to add Javadoc :)

@damondouglas damondouglas marked this pull request as ready for review August 5, 2024 18:29
Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damondouglas damondouglas merged commit 99a2383 into apache:master Aug 6, 2024
18 checks passed
@damondouglas damondouglas deleted the prism-runner-artifact-svc branch August 6, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Prism][Task]: Enable artifact staging during Prism Runner lifecycle
2 participants