Fix build_wheels and build_release_candidate #32725
Merged
+13
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abacn
force-pushed
the
fix-release-workflows
branch
from
cb2b44f
to
431f9a2
Compare
lostluck
reviewed
Oct 9, 2024
.github/workflows/build_wheels.yml
Outdated
| @@ -96,7 +96,7 @@ jobs: | |||
| - name: Get tag | |||
| id: get_tag | |||
| run: | | |||
| echo "TAG=${GITHUB_REF#refs/*/}" >> $GITHUB_OUTPUT | |||
| echo "TAG=v2.60.0-RC0" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
We probably want this one change to be in a separate PR entirely, and then just run the workflow(s) from a branch with this one value changed, instead of running them from master.
There was a problem hiding this comment.
Yes, this line is not intended to make into the PR when it is ready for review. Closing this PR and will open another one for review purpose. (actually let me re-open it since it is still needed for upcoming RC)
I was using this branch to run build_wheels for 2.60.0rc1 after it was failed on push trigger.
Abacn
force-pushed
the
fix-release-workflows
branch
4 times, most recently
from
8e7a439
to
afd370c
Compare
Abacn
force-pushed
the
fix-release-workflows
branch
from
afd370c
to
9ba4332
Compare
Abacn
force-pushed
the
fix-release-workflows
branch
from
9ba4332
to
2b2467a
Compare
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Abacn
added a commit
to Abacn/beam
that referenced
this pull request
Oct 11, 2024
* Fix build_wheels and build_release_candidate
Abacn
added a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.