Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the FlinkRunner for Dataproc #32737

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

liferoad
Copy link
Collaborator

  1. Fix the dataproc Flink version
  2. Make sure the Flink cluster has the external IPs.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@liferoad
Copy link
Collaborator Author

To make the notebook running fine with Dataproc Flink, we also need to do this:

from apache_beam.options.pipeline_options import DebugOptions
options.view_as(DebugOptions).add_experiment('disable_logging_submission_environment')

@liferoad liferoad marked this pull request as ready for review October 10, 2024 17:01
@nika-qubit nika-qubit self-requested a review October 10, 2024 17:08
Copy link
Contributor

@nika-qubit nika-qubit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

@liferoad
Copy link
Collaborator Author

@tvalentyn @damccorm FYI

@liferoad liferoad merged commit 2049e6b into apache:master Oct 10, 2024
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants